-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert PR#123 changes in favor of pydata-sphinx-theme v0.7.0 #160
Conversation
This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below. 🔍 Git commit SHA: e734b4f |
There is an issue here, which I could not figure out yet and will not have the availability for a while to further work on it:
So, it looks like You are welcome to look into this issue; otherwise, I will need to close this until I have time to look into it again (This PR is not urgent as our Google Analytics config is currently working fine) |
Yes, it seems that the conda-forge recipe for
which you can find here: |
So maybe we just need to let this simmer until things get updated upstream. |
Oh, thanks for this, I didn't look at it. |
Opened Issue#423 at sphinx-book-theme for this. |
Now that there's a new version of |
Yes, I will, thanks! |
Yes. With the newest release, the Jupyter Book config option for GA should work, even with newer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks, @erogluorhan!
Closes #128 by reverting the changes of PR #123.
pydata-sphinx-theme released v0.7.0 that fixes their Google Analytics handling.