Wrap analytics id in quotes #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 📚 Preview for git commit SHA: a2d2185 at: https://611566abd4ebe6104dde867f--pythia-foundations.netlify.app |
|
@kmpaul I suggest merging this and see if it get the analytics working. I'm not sure we have a way to test this without merging first. |
|
If this doesn't work, then we might be able to wait for a fix: jupyter-book/jupyter-book#1300 |
|
I don't think this fixed anything, sadly. I can't be 100% sure, but I don't see any differences in the actual HTML generated for the page. |
|
Ok! I suppose my Climate Laboratory book must be using an "old style" Google Analytics ID, though I'm not yet clear what that means. |
|
Does it start with a UA-? Or a G-? The first is the old and the second is the new. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might get the google analytics working for the Foundations site.
I noticed that my other JupyterBook site (which has working analytics) wrapped the ID in double quotes:
https://github.com/brian-rose/ClimateLaboratoryBook/blob/87801650d5f2e374494d8ccfc955b2a3b3000254/_config.yml#L45
This is consistent with the JupyterBook config reference, which shows double quotes:
https://jupyterbook.org/customize/config.html
I tried using double quotes here, but prettier insisted on changing them to single quotes.