Fit 01_Cartopy_Intro notebook to proposed Foundations template #57
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
🚀 📚 Preview for git commit SHA: 3d88327 at: https://60b005e29c6ddd1fd50c9665--pythia-foundations.netlify.app |
|
I think to fit the template, we need to avoid using subheadings for text blocks, particularly because they clutter up the right-hand nav bar when rendered in the Jupyterbook. I'll push an update to this branch that has a more vanilla usage of subheading markers. |
|
@ktyle I removed a lot of subheading markers in text blocks, but also tried to add useful subheadings that will render well in the nav bar. Let me know what you think. |
|
🚀 📚 Preview for git commit SHA: dbd5f72 at: https://60b0192b729f6c41ac807050--pythia-foundations.netlify.app |
|
This should probably be revisited one more time as soon as the template is finalized and merged. |
|
🚀 📚 Preview for git commit SHA: 0b9ffdd at: https://60bf8e82fd59d63b5ea342a4--pythia-foundations.netlify.app |
|
🚀 📚 Preview for git commit SHA: ab35744 at: https://60bf910c3bced800994c9b07--pythia-foundations.netlify.app |
|
🚀 📚 Preview for git commit SHA: e6693ba at: https://60bf94d0ec5aa200b0444565--pythia-foundations.netlify.app |
|
Ok team, I did some further massaging of this notebook to make it (I think) fully consistent with our new template. I also added the self-generating Cartopy logo at the top of the notebook using code from https://scitools.org.uk/cartopy/docs/latest/gallery/miscellanea/logo.html @ktyle is this ready for a formal review? If so, please request from the Education team. (I see that you "assigned" some of us to this already, feel free to tag the same people for review or tag the team instead to use the round-robin functionality) |
ktyle
requested review from
a team,
brian-rose and
r-ford
and removed request for
a team
|
@brian-rose looks great! Ready for review and merge. I selected the Education team so hopefully the reviewers got assigned properly. |
|
Side note, we should (temporarily) remove @r-ford from the team so he doesn't get tagged for reviews during tomorrow's hackathon. |
|
View / edit / reply to this conversation on ReviewNB mgrover1 commented on 2021-06-08T18:42:22Z Can you separate the cartopy.feature as cfeature into a different line? ktyle commented on 2021-06-08T19:03:56Z That's how I originally had it, and I prefer it that way too! But as I recall it got flagged by the linter in favor of this usage. mgrover1 commented on 2021-06-08T21:08:28Z Ahh okay! |
|
View / edit / reply to this conversation on ReviewNB mgrover1 commented on 2021-06-08T18:42:23Z there is a weird space here in the rendering ktyle commented on 2021-06-09T15:35:43Z Ok I removed the extraneous space preceding the final sentence. I also added a clarification that |
|
View / edit / reply to this conversation on ReviewNB mgrover1 commented on 2021-06-08T18:42:24Z Consider making this a hyperlink? ktyle commented on 2021-06-09T15:38:03Z Hmm it already is ... do you mean that the text within the link should say something other than the full URL? |
|
View / edit / reply to this conversation on ReviewNB mgrover1 commented on 2021-06-08T18:42:24Z Hyperlink here too ktyle commented on 2021-06-09T15:38:33Z same as previous comment |
|
View / edit / reply to this conversation on ReviewNB mgrover1 commented on 2021-06-08T18:42:25Z Is there a better name we could use here? Maybe labels? ktyle commented on 2021-06-09T15:39:35Z Do you mean substitute Info with Labels? mgrover1 commented on 2021-06-09T15:56:36Z Yes - I think that would be more informative ktyle commented on 2021-06-09T16:03:42Z (resolved; this issue was a consequence of how reviewNB renders some Markdown cells, such as the alert admonitions) |
|
View / edit / reply to this conversation on ReviewNB mgrover1 commented on 2021-06-08T18:42:26Z Why is #3 italicized? ktyle commented on 2021-06-09T15:41:04Z Fixed :) |
mgrover1
left a comment
mgrover1
left a comment
There was a problem hiding this comment.
I added a few comments/suggestions via nbviewer - the markdown file looks great. Awesome work!
|
That's how I originally had it, and I prefer it that way too! But as I recall it got flagged by the linter in favor of this usage. View entire conversation on ReviewNB |
|
Ahh okay! View entire conversation on ReviewNB |
|
Ok I removed the extraneous space preceding the final sentence. I also added a clarification that View entire conversation on ReviewNB |
|
Hmm it already is ... do you mean that the text within the link should say something other than the full URL? View entire conversation on ReviewNB |
|
same as previous comment View entire conversation on ReviewNB |
|
Do you mean substitute Info with Labels? View entire conversation on ReviewNB |
|
Fixed :) View entire conversation on ReviewNB |
|
Yes - I think that would be more informative View entire conversation on ReviewNB |
|
(resolved; this issue was a consequence of how reviewNB renders some Markdown cells, such as the alert admonitions) View entire conversation on ReviewNB |
|
🚀 📚 Preview for git commit SHA: c71c9c7 at: https://60c0e89cb198cb00b42bfe29--pythia-foundations.netlify.app |
|
woo-hoo! |
6 participants
I've reworked the intro to cartopy notebook so it fits the proposed foundations template that @dcamron developed on the 5/27 hackathon