Handle case in _configure_openmp() for MacOS system without Homebrew #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…mebrew On a MacOS system that's not using Homebrew, running `brew --prefix llvm` with `subprocess.check_output` doesn't produce a CalledProcessError; instead, when the shell produces a FileNotFoundError it passes it back and `check_output` raises that instead. If we check for OSError (the parent of FileNotFoundError, which should handle other OS-related errors that could get passed back) as well, then this should correctly handle this case. The MacPorts check doesn't have the same issue, because the `which` command is built in and so `which port` will raise a CalledProcessError if MacPorts isn't installed.
isobelhooper
force-pushed
the
handle-macos-without-brew-in-setup-py
branch
from
61334fd
to
a71f3d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a MacOS system that's not using Homebrew, running
brew --prefix llvmwithsubprocess.check_outputdoesn't produce a CalledProcessError; instead, when the shell produces a FileNotFoundError it passes it back andcheck_outputraises that instead.If we check for OSError (the parent of FileNotFoundError, which should handle other OS-related errors that could get passed back) as well, then this should correctly handle this case.
The MacPorts check doesn't have the same issue, because the
whichcommand is built in and sowhich portwill raise a CalledProcessError if MacPorts isn't installed.