Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Getting Close To Completing a Neighborhood, The Mission Dialog Could Say 0.0 Miles Left to Go But Still Give You Another Mission #1094

Closed
jonfroehlich opened this issue Sep 15, 2017 · 2 comments

Comments

@jonfroehlich
Copy link
Member

Due to how we round and/or display the amount of miles remaining in a neighborhood, when you get close to completing one, you could get a Mission Complete Dialog that says 0.0 miles remaining but then there is still some amount left (e.g., 0.04 miles) and so you're given another mission. This is confusing. So, anything > 0, should be displayed as 0.1 miles in this dialog.

image

See: https://youtu.be/6EnmhTRITdk?t=9s. Note how the mission afterwards is the 100% neighborhood completion, which is correct.

@jstadeusiak
Copy link
Collaborator

Done! Will submit PR when I get done cleaning up other issues.

misaugstad added a commit that referenced this issue Aug 23, 2020
…tion-rounding-fix

#1094 Fixed Rounding for remaning neighborhood distance
@misaugstad
Copy link
Member

closing via #2210

@misaugstad misaugstad mentioned this issue Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants