Assignment count < Completion count in the street edge assignment table

[manaswisaha]

The assignment count is less than the completion count for a street edge. This should not be the case. I don't think it has dire consequences but this should be investigated and fixed.

Example regions to check are 204 and 205. Here is the screenshot showing a sample of that (in region 205):

3rd column is the assignment count and 4th is the completion count.

Query used to generate this: select * from street_edge_assignment_count where street_edge_id IN (select street_edge_id from street_edge_region where region_id = 204);

[jonfroehlich]

Can you explain this a bit more?

…

On Mon, Oct 9, 2017 at 8:11 AM, Manaswi Saha ***@***.***> wrote: The assignment count is less than the completion count for a street edge. This should not be the case. I don't think it has dire consequences but this should be investigated and fixed. Example regions to check are 204 and 205. Here is the screenshot showing a sample of that (in region 205): [image: image] <https://user-images.githubusercontent.com/2873216/31344947-15736a26-acc9-11e7-986c-cd8379ab7563.png> 3rd column is assignment count and 4th is completion count. Query used to generate this: select * from street_edge_assignment_count where street_edge_id IN (select street_edge_id from street_edge_region where region_id = 204); — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1135>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABi-9Yqv3jzXnOuRCsNcQb97mmdcL1TRks5sqjeKgaJpZM4Pyo2l> .

-- Jon Froehlich Associate Professor Paul G. Allen School of Computer Science & Engineering University of Washington http://www.cs.umd.edu/~jonf/ http://makeabilitylab.io @jonfroehlich <https://twitter.com/jonfroehlich> - Twitter

[manaswisaha]

Assignment count is the number of times a street has been assigned to users for auditing. They might not audit it, so that would result into 0 completion count for those, but any street that is assigned for auditing should have an assignment count of at least 1.

So it seems wrong to have streets that have >0 completion count but 0 assignment count.

So to investigate this we have to confirm whether the code is based on this logic or not. Intuitively, this should be the logic. This old code has not been modified since the very beginning, hence bugs (if they were present from the very beginning) didn't surface before now since we are actively using this table to assign least audited routes using the completion count column. To my knowledge, we don't use assignment count for anything significant yet.

[jonfroehlich]

Thanks for clarifying. Does sound problematic.

…

On Mon, Oct 9, 2017 at 10:42 AM, Manaswi Saha ***@***.***> wrote: Assignment count is the number of times a street has been assigned to users for auditing. They might not audit it, so that would result into 0 completion count for those, but any street that is assigned for auditing should have an assignment count of at least 1. *So it seems wrong to have streets that have >0 completion count but 0 assignment count*. So to investigate this we have to confirm whether the code is based on this logic or not. Intuitively, this should be the logic. This old code has not been modified since the very beginning, hence bugs (if they were present from the very beginning) didn't surface before now since we are actively using this table to assign least audited routes using the completion count column. To my knowledge, we don't use assignment count for anything significant yet. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1135 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABi-9TZ_ep0Nn8A4JoYacsqd18jJW-PUks5sqlsSgaJpZM4Pyo2l> .

-- Jon Froehlich Associate Professor Paul G. Allen School of Computer Science & Engineering University of Washington http://www.cs.umd.edu/~jonf/ http://makeabilitylab.io @jonfroehlich <https://twitter.com/jonfroehlich> - Twitter

[misaugstad]

possible bug fix for @Adash12 to work on?

[misaugstad]

I actually don't think that we use assignment and completion count directly anymore. We now base our street priority on the "good user audit count", so I don't think this table really has a use, except to as a pre-computed value that we look at on the admin page. However, this isn't the most time-consuming thing to compute, so I think we could just delete this table entirely.

[misaugstad]

We opted to just remove this table. Closing via #1328