Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider bringing back 'observed area' feedback #1316

Closed
jonfroehlich opened this issue Sep 16, 2018 · 7 comments · Fixed by #2860
Closed

Consider bringing back 'observed area' feedback #1316

jonfroehlich opened this issue Sep 16, 2018 · 7 comments · Fixed by #2860

Comments

@jonfroehlich
Copy link
Member

jonfroehlich commented Sep 16, 2018

We tracked and visualized the observed area in Tohme's top-down map--and actually forced workers, I believe, to look 360 degrees before submitting their work:

image

@misaugstad
Copy link
Member

@shokiami and I talked about this today and I think it's a great task for him to take on this quarter! Just showing this feedback to users will encourage them to audit more carefully (even if we don't force them to look everywhere). I think it can also encourage users to label things more close to them if we let the this observed area only extend a short-ish distance from where you're located!

@jonfroehlich
Copy link
Member Author

Nice, great idea. Looking forward to seeing what you can come up with @shokiami!

@shokiami
Copy link
Collaborator

@jonfroehlich @misaugstad
Just wanted to share what it currently looks like!
ObservedArea

@jonfroehlich
Copy link
Member Author

jonfroehlich commented May 28, 2021 via email

@shokiami
Copy link
Collaborator

@jonfroehlich @misaugstad
Yup, it's possible! I have two constants I'm using which represent the width and height of the canvas (in latitude and longitude). That being said, I feel like the smaller box better represents the area the user can see at the moment. Thoughts?
Also, I just added the functionality so that the polygon takes into account what you've observed from the previous screen! Take a look:

  1. Let's say a user fully scanned an area.

1

2. This is what they would see when they take a step!

2

Also, for reference, this is what it looks like when I don't clear the previous region when stepping. The calculation essentially entails finding where the two regions intersect.
3

@misaugstad
Copy link
Member

Also, for reference, this is what it looks like when I don't clear the previous region when stepping. The calculation essentially entails finding where the two regions intersect.

I think you want to use something like this, but the polygons should probably be combined to just a single polygon so that you aren't seeing something different on the overlap. You can see all the examples @isavin12 added in #1324 do it that way. But maybe that was always your plan and you're just showing progress as you go along :)

@jonfroehlich
Copy link
Member Author

@shokiami and I discussed this on our call today. We decided that either the "fog-of-war" should take up the whole top-down map—as now, it's only a subset as a small square—or, instead of the square, we could do a circle.

@shokiami also mentioned using the turf.js library to engineer this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants