Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show total validations on mission complete screen #2130

Closed
misaugstad opened this issue Jun 8, 2020 · 18 comments
Closed

Show total validations on mission complete screen #2130

misaugstad opened this issue Jun 8, 2020 · 18 comments

Comments

@misaugstad
Copy link
Member

Related to #1776

We are already keeping track of this on the front-end from issue #1776, so it would be easy to add it to the mission complete modal.

File

@misaugstad
Copy link
Member Author

@shokiami please make a mock of what you're proposing to make the modal look like first before starting implementation. That way we can iterate on the design before you start diving into the code.

@shokiami
Copy link
Collaborator

@misaugstad Here are two mock ideas that utilize different message types (straight forward vs celebratory) and two different text placements. Please let me know what you feel is more user-friendly. Also, do you think it would be fun to change up the font/color of the text?
mock1.pdf
mock2.pdf

@jonfroehlich
Copy link
Member

@shokiami for convenience and skimmability, please don't embed your mocks in PDFs (unless they are substantial in length). Instead, just screenshot them here.

I probably prefer Design 1. But we should only use one 'exclamation mark' (probably after Great Job!). So, the sentence would be: "You just validated 10 Missing Curb Ramp labels. Great Job!"

Design 1:
image

Design 2:
image

@shokiami
Copy link
Collaborator

@jonfroehlich Sounds good! I have attached two new designs that I wanted to quickly run by you. Design 1 is based on your previous suggestion, while Design 2 maintains the original order of the "Great Job! You just validated..." message and displays the "Total Validations" at the bottom as well as without the extra hyphens. I am happy to follow through with any combination of these formats. Please let me know what you prefer.

Also, I didn't realize pdfs do not display in comments, so thanks for the feedback!

Design 1:
design1

Design 2:
design2

@jonfroehlich
Copy link
Member

jonfroehlich commented Jun 27, 2020 via email

@shokiami
Copy link
Collaborator

@jonfroehlich Sure thing!
84070790-8bd3a480-a981-11ea-816e-11729cee29a5

@misaugstad
Copy link
Member Author

Hmm I'm not sure I like it in the table as much as the other options. Do you have thoughts @jonfroehlich ?

@jonfroehlich
Copy link
Member

I like the last one the best. Let's thicken that last line (like 2pt or 3pt line width) to distinguish it.

@shokiami
Copy link
Collaborator

@jonfroehlich Sounds good!

@misaugstad What do you think?

85933215-71f2f680-b889-11ea-9c59-114a35267c3f

@jonfroehlich
Copy link
Member

jonfroehlich commented Jun 29, 2020 via email

@shokiami
Copy link
Collaborator

@jonfroehlich How does that look?

86053310-28331900-ba0d-11ea-9aab-0ca2f6301345

@jonfroehlich
Copy link
Member

jonfroehlich commented Jun 29, 2020 via email

@shokiami
Copy link
Collaborator

@jonfroehlich "Overall Validations" makes sense to me. However, I hear your concern. How do you feel about "Your Total/Overall Validations"? Or is that too many words?

@jonfroehlich
Copy link
Member

jonfroehlich commented Jun 30, 2020 via email

@shokiami
Copy link
Collaborator

@jonfroehlich Hmmm... I wonder if it is intuitive to the user what the number is referring to. What do you think?

design1

design2

@jonfroehlich
Copy link
Member

jonfroehlich commented Jun 30, 2020 via email

@shokiami
Copy link
Collaborator

@jonfroehlich Sounds good!

misaugstad added a commit that referenced this issue Jul 9, 2020
…ow-total-validations

#2130 Show total validations on mission complete screen
@misaugstad
Copy link
Member Author

closing via #2163

@misaugstad misaugstad mentioned this issue Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants