Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporary_label_id stored as Option[Int] in Database #2133

Closed
michaelduan8 opened this issue Jun 10, 2020 · 1 comment · Fixed by #3408
Closed

temporary_label_id stored as Option[Int] in Database #2133

michaelduan8 opened this issue Jun 10, 2020 · 1 comment · Fixed by #3408

Comments

@michaelduan8
Copy link
Collaborator

As described in the title, temporary_label_ids (which are used to locate labelId in the database upon form submission, for example) are stored as Option[Int], which seems strange considering how it is needed to identify if a label already exists in the database

@misaugstad
Copy link
Member

I checked all the databases, and it seems that the temporary_label_id is not null for any label except in the DC database. But the DC database is using the old code base anyway. So we may as well switch this to appropriately require non-null temporary label IDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants