-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added non-null constraint to temporary_label_id #3408
Conversation
Ahh, so we actually only wanted to change this for the |
yup, updated it. ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh you still need to update the Label
Scala class to use an Int
instead of Option[Int]
!
And since you're already making an update, making the comment in the SQL file match the style would be nice :)
ready for review (assuming you just wanted a period added to the sql file). |
And starting with a capital letter, but I can change that if everything else checks out ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @dylanbun!!
Resolves #2133
Changed the temporary_label_id column in the label and audit task interaction table to be from null to non-null.