Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default PR (and issue) template #2190

Closed
misaugstad opened this issue Jul 27, 2020 · 2 comments · Fixed by #2192
Closed

Add a default PR (and issue) template #2190

misaugstad opened this issue Jul 27, 2020 · 2 comments · Fixed by #2192

Comments

@misaugstad
Copy link
Member

I really want to add a default PR template that can serve both as a checklist of things to check for before submitting a PR, and as a way to improve documentation in the PR. I looked into this a bit a few weeks ago and found that it was more complicated than just setting something up on the Github website, so I didn't go through with it then. But I'd really like to now.

@shokiami would you be able figure out how to set up a PR template (ideally an issue template as well)? You can just add a super super basic stand in one; I will write the whole thing after you get it set up, I just would appreciate the help in getting it set up in the first place!

@jonfroehlich
Copy link
Member

@misaugstad shouldn't this be closed. Seems like there are templates both for Issues and PRs now...

@misaugstad
Copy link
Member Author

Ahh yes I had not tried to make a new PR to test that it works since the most recent merge into master. Just checked and it's working, so yeah I'll close it. Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants