New label icons need to have white/black outlines?

[jonfroehlich]

I noticed that sometimes it's hard for my eye to find the labeling icons in the validation interface, especially the more muted green for the curb ramp icon.

I then realized that we no longer have black/white outlines around the labeling icons (like we used to with the old labels):

Old Labels

White outlines:

Black outlines:

Suggestion

We could have a two-color outline: black (1 pt) then white (1 pt), which would work across background types (that's how mouse cursor icons work). Alternatively, we could have adaptive outlines based on background image (but this is more complicated and probably not worth the effort).

[misaugstad]

@jonfroehlich are you suggesting that we edit the icon images to have those outlines? Or to add them in the JS/CSS? I'm assuming you mean the former, but I just want to be sure before I start messing with them ;)

[jonfroehlich]

CSS

On Fri, Mar 11, 2022 at 3:55 PM Mikey Saugstad ***@***.***> wrote: Reopened #2807 <#2807>. — Reply to this email directly, view it on GitHub <#2807 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAML55NEADUSK7PPP2Q7Z4TU7PMONANCNFSM5QKQODPQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.*** com>

-- Sent from phone

[bnelson05]

Here's what the different line widths I experimented with look like @jonfroehlich :

0.3:

0.5:

0.7:

1:

[misaugstad]

Let's go with 0.5 for now. I can actually see the contrast without it feeling like it's taking up too much space!

[jonfroehlich]

Yah, I like 0.5 too! Thanks team!