Validate mission start screens messed up when there are no labels to validate

[misaugstad]

Brief description of problem/feature

We used to have a screen that was shown on Validate immediately upon loading the page if there were no labels available to validate that would direct them to the Explore page to collect more data. This only really happens when a server is very new and not much data has been collected. With the new mission screens, we forgot to check for this edge case, so in Taipei we just see this:

This page is still available on mobile though!

[jonfroehlich]

Can confirm that our system crashes on this. In preparation for our Auckland phone call, I was doing validations--and it looks like I ran out of labels to validate! 😂

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'remove')
    at SVValidate.js:2488:49
    at streetview.js:65:132
    at streetview.js:97:267

Then I tried it in a new window and got this:

@misaugstad and I think this might be because I validated all labels in Auckland and there is nothing left

[misaugstad]

We didn't remove the code for this, we just broke it somehow 😁 I think it has to do with how we used to use the same HTML elements for the mission start screen and the screen where we say that there are no more missions left. So we were just editing the text on that screen.

Now what we probably need to do is when there are no labels to validate is to hide our usual mission screen, and show the old one instead (with the correct text). You can see a pic below of what it looked like at one point in time:

Given that very few users will ever see this screen, I'm find with using the ugly version that we have ;) Most of the code for it is in ModalNoNewMission.js!

[misaugstad]

And you should be able to temporarily edit the back-end code to return no labels to the front-end to test this temporarily!

We should make sure that this works when there are no labels to start, and if you finish one mission and aren't able to do another one after it because we're out of labels!

[jonfroehlich]

Just came here to humbly say that this is still a problem and now quite evident on our new Cuenca server :)

[jonfroehlich]

On the new Keelung server, I was able to get past the initial mission screen but then the validation UI loaded and looks like this:

[kevinjtwu]

I think I've replicated the issue by editing the backend to return a null JsValue

[kevinjtwu]

What should we do on mobile? The no new missions screen asks the user to explore, but we can't explore on mobile.

[kevinjtwu]

What should we do on mobile? The no new missions screen asks the user to explore, but we can't explore on mobile.

Currently, clicking on 'Start Exploring' redirects the user to the Seattle server to validate labels.

[misaugstad]

It looks like at the bottom of ModealNoNewMission.js the test for that was set with this line

uiModalMission.closeButton.html(i18next.t('mission-complete.no-new-mission-button') + ` Seattle, WA`);