Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes no new missions #3394

Merged
merged 7 commits into from
Oct 23, 2023
Merged

Fixes no new missions #3394

merged 7 commits into from
Oct 23, 2023

Conversation

kevinjtwu
Copy link
Collaborator

Resolves #3126

Fixes broken "no more validation missions left" screen when there are no more labels to validate. Adds different functionality for mobile, as well as translations.

Before/After screenshots (if applicable)

Before:
3126-validate-no-new-mission_bug1

After:
3126-validate-no-new-mission_fix1
3126-validate-no-new-mission_fix2

Testing instructions
  1. Force else case in getDataForValidationPages() in ValidationController.scala by temporarily editing if statement to 'if (false)'
  2. Navigate to Validate webpage
  3. Use Dev Tools to test mobile version
Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've included before/after screenshots above.
  • I've asked for and included translations for any user facing text that was added or modified.
  • I've tested on mobile (only needed for validation page).

Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some quick testing and found some issues!

  1. When finishing a mission and there are labels left to validate, the "Validate more labels" button is now broken on both mobile and desktop! Make sure to test thoroughly!!
  2. The text in the button on mobile when you're out of labels is too small
    image0

Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinjtwu! I updated the CSS slightly so that the button is wider and doesn't wrap to two lines. Otherwise looks good.

I think that they CSS and stuff is really messy, but these screens aren't seen very much and really need an overhaul, so I'm not as worried about making them perfect.

@misaugstad misaugstad merged commit 4ffba4f into develop Oct 23, 2023
@misaugstad misaugstad deleted the 3126-validate-mission-start branch October 23, 2023 20:42
@misaugstad misaugstad mentioned this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate mission start screens messed up when there are no labels to validate
2 participants