Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "source" column in the label_validation table #3164

Closed
misaugstad opened this issue Mar 8, 2023 · 4 comments · Fixed by #3380
Closed

Add a "source" column in the label_validation table #3164

misaugstad opened this issue Mar 8, 2023 · 4 comments · Fixed by #3380

Comments

@misaugstad
Copy link
Member

Brief description of problem/feature

Maybe think of a better name than "interface", but ultimately we should have an easy indication of which interface was used for validating. I think that we can at least mostly figure this out from other information, but we should just have a column in the label_validation table for it. Values would be "ValidateDesktop", "ValidateMobile" (and we can then remove the is_mobile column), "GalleryCard", "GalleryExpanded", "LabelMap", "AdminLabelMap", "AdminLabelSearch", "AdminContributions", etc.

@jonfroehlich
Copy link
Member

Nice idea. How about ValidationSource?

@misaugstad
Copy link
Member Author

yeah that's better 😁

@misaugstad misaugstad changed the title Add an "interface" column in the label_validation table Add a "source" column in the label_validation table Mar 10, 2023
@misaugstad
Copy link
Member Author

Maybe just source! It's already called the label_validation table, so validation_source is a little bit redundant.

@jonfroehlich
Copy link
Member

jonfroehlich commented Mar 10, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants