added source col, removed mobile column from label validation table

[dylanbun]

Resolves #3164

Added a new column, source. Logs locations of where users did their validations. Possiblities are GalleryCard, GalleryExpanded, LabelMap, ValidateDesktop, ValidateMobile, AdminLabelMap, AdminLabelSearch, AdminUserDashboard, and AdminContributionPage. Since we now have a way to distinguish between ValidateDesktop and ValidateMobile, removed the is_mobile column from the label validation table.

Before/After screenshots (if applicable)

Before:

After:

Testing instructions

1. Go to Project Sidewalk and start testing various forms of validation
2. Go to label validation table and confirm correct sources for each validation type.

Things to check before submitting the PR

• I've written a descriptive PR title.
• I've added/updated comments for large or confusing blocks of code.
• I've included before/after screenshots above.
• I've tested on mobile (only needed for validation page).

[dylanbun]

@misaugstad can you confirm if this is_mobile should not be removed? Thanks!

[misaugstad]

Is it being used anywhere that you haven't removed? Is there a reason that you're not sure if this one should be removed?

[misaugstad]

removed the is_mobile column from the label validation table

Did you mark the previous mobile ones as ValidateMobile in your new column? And IIRC, validations through both the Validate page had a different mission type from all the other validations, so I think that we could tell which ones were ValidateDesktop as well?

[dylanbun]

Did you mark the previous mobile ones as ValidateMobile in your new column?

Whoops! No, I did not but I just added to that latest commit.

And IIRC, validations through both the Validate page had a different mission type from all the other validations, so I think that we could tell which ones were ValidateDesktop as well?

If I am understanding this correctly are you saying we could also update the source column for certain existing rows as "ValidateDesktop" ? I would think so but just to make sure isn't that just based on the canvas height and width (height: 440, width: 720?).

[misaugstad]

If I am understanding this correctly are you saying we could also update the source column for certain existing rows as "ValidateDesktop" ? I would think so but just to make sure isn't that just based on the canvas height and width (height: 440, width: 720?).

No I was thinking about the mission_type table which has one called validation and one called labelmapValidation. I believe that we had just mashed everything except for ValidateMobile and ValidateDesktop into the labelmapValidation mission type.

This was done because validations needed to be tied to missions, the Validate missions are set to 10 labels, but doing a validation through LabelMap, Gallery, etc. doesn't have a specific number of labels in the mission, so we just made a new mission type for them.

I'm assuming we could use this to figure out which ones are from the Validate page. Though everything else hasn't been delineated in a way that we could use.

[dylanbun]

@misaugstad ready for review!

[misaugstad]

Looking pretty good, just looking to fix a couple things and rename a few other things!

[dylanbun]

@misaugstad ready for review!

[misaugstad]

Looks great, thank you @dylanbun !!