Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some JSON APIs can be missing the occasional comma #3334

Closed
misaugstad opened this issue Aug 2, 2023 · 2 comments · Fixed by #3335
Closed

Some JSON APIs can be missing the occasional comma #3334

misaugstad opened this issue Aug 2, 2023 · 2 comments · Fixed by #3335
Assignees
@misaugstad
Labels
API Bug Easy Fix

Comments

@misaugstad
Copy link
Member

Brief description of problem/feature

It looks like I made a small mistake when I "improved" API performance in #3224... Specifically for the JSON APIs, we are missing a comma once every 10k labels 🙃 It seems that whatever I was using to test the output automatically fixed those issues for me so I didn't see them...

It's a quick/easy fix!
@misaugstad misaugstad self-assigned this Aug 2, 2023
@jonfroehlich
Copy link
Member

Doh!

How did you notice this? Was it @crescendochu using one of the APIs?

@misaugstad
Copy link
Member Author

Yes it was! Sorry @crescendochu 😭

@misaugstad misaugstad mentioned this issue Aug 2, 2023
Merged
@misaugstad misaugstad mentioned this issue Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@misaugstad misaugstad

Labels
API Bug Easy Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes missing commas in JSON APIs ProjectSidewalk/SidewalkWebpage
2 participants
@jonfroehlich @misaugstad