Fixes missing commas in JSON APIs #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3334
Fixes an issue where a comma was being missed every 10k labels in the
/v2/access/attributes,/v2/access/attributesWithLabels, and/adminapi/labels/cvMetadataAPIs. In #3276 I switched us to adding 10k labels at a time to a JSON file to prevent the server from running out of heap space, but I forgot to include a comma between every 10k 🤦Testing instructions
I tested on a database that had 35k labels on my local dev env and tried each of the three API endpoints. I used this site to validate the JSON.