Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate mission start title not showing number of labels to validate #3376

Closed
misaugstad opened this issue Aug 25, 2023 · 0 comments · Fixed by #3421
Closed

Validate mission start title not showing number of labels to validate #3376

misaugstad opened this issue Aug 25, 2023 · 0 comments · Fixed by #3421

Comments

@misaugstad
Copy link
Member

misaugstad commented Aug 25, 2023

Brief description of problem/feature

As pointed out by Frank (a partner in our Taiwan deployment), the count for the number of labels is not showing up in the mission start tutorial on the Validate page. In the pic below, the title should say "Validate 10 Surface Problem Labels".
Screenshot from 2023-08-25 14-07-15

Potential solution(s)

The translations in validate.json (with the key mst-instruction-2) seem to be correct. If I manually enter the following into the console, I get the correct answer.

i18next.t('validate:mission-start-tutorial.mst-instruction-2',{'nLabels': 10, 'labelType': i18next.t('common:surface-problem')});

So maybe we aren't passing in the label count correctly anymore!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants