Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

City names and translations #3377

Closed
jonfroehlich opened this issue Aug 28, 2023 · 1 comment · Fixed by #3387
Closed

City names and translations #3377

jonfroehlich opened this issue Aug 28, 2023 · 1 comment · Fixed by #3387
Assignees

Comments

@jonfroehlich
Copy link
Member

Received an email from Frank that said:

I've noticed the city names in the intro window stay in English even after the language selection has been set to other languages (for example Chinese). Could you guys fix that so that the city name also convert? Example screenshot below showing "New Taipei" (in English).

image

In the same email, he also asked us to make another city-name related fix:

Also each city area that we have opened in Taiwan (Taipei, New Taipei, and Keelung), for those cities to be correctly referred to in Chinese, after each city name, the Chinese word for "City" (市) has to be inserted, otherwise it's not a proper name. Could this be handled in the code just like the other translations terms?

@misaugstad
Copy link
Member

Just recording that I'm getting Chinese names for US states here.

@misaugstad misaugstad mentioned this issue Sep 29, 2023
@misaugstad misaugstad moved this to done / on test servers in Mikey Task Board May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: done / on test servers
Development

Successfully merging a pull request may close this issue.

2 participants