Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

City names are now translated #3387

Merged
merged 12 commits into from
Sep 21, 2023
Merged

City names are now translated #3387

merged 12 commits into from
Sep 21, 2023

Conversation

misaugstad
Copy link
Member

Resolves #3377
Resolves #3384

Summary of changes:

  1. Names of cities, states, and countries now translated into all supported languages (City names and translations #3377)
  2. Formatting for location names has been fixed as well (only matters for Chinese, which is ordered from largest; country, state, city).
  3. Now showing "city, country" instead of "city, state" for US cities when on non-US servers
  4. List of cities are now sorted by country and then city instead of just by city name (Organize cities dropdown list by country #3384)

These changes can be seen:

  • In the drop-down list of cities in the navbar
  • In the drop-down list of cities in Gallery
  • Various places on the landing page
  • Various places on the Explore page
  • Access Score Demo
Before/After screenshots (if applicable)

Before (English)
Screenshot from 2023-09-21 12-54-15

After (English)
Screenshot from 2023-09-21 12-52-27

Before (Spanish)
Screenshot from 2023-09-21 12-54-27

After (Spanish)
Screenshot from 2023-09-21 12-52-01

Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've added/updated comments for large or confusing blocks of code.
  • I've included before/after screenshots above.
  • I've asked for and included translations for any user facing text that was added or modified.

@misaugstad misaugstad self-assigned this Sep 21, 2023
@misaugstad misaugstad merged commit 934bbb4 into develop Sep 21, 2023
@misaugstad misaugstad deleted the 3377-translate-city-names branch September 21, 2023 20:03
@misaugstad misaugstad mentioned this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organize cities dropdown list by country City names and translations
1 participant