Resolves #1255: fixes duplicate pano id logging #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid duplicate logging
…oid duplicate logging
ghost
assigned 
…Webpage into 1255-fix-duplicate-pano-id-change
|
Works great, nicely done! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1255.
The Google Maps 'pano_changed' listener is triggered twice when we switch panoramas: once when we are transitioning between panoramas, and once when we set the new panorama. I added a check to see if it was the same as the previous panorama ID that was logged.
Testing Instructions
Go to the audit screen and try to walk around a bit. You can try stress-testing the system by rapid clicking the Street View arrows.