Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #976: Fixes initial blank panorama #1311

Merged
merged 1 commit into from
Sep 1, 2018

Conversation

aileenzeng
Copy link
Member

@aileenzeng aileenzeng commented Aug 28, 2018

Fixes #976

The blank panorama is caused by a bug in the Google StreetView API that doesn't load the panorama w/ the PanoID correctly the first time. There was a workaround we used earlier of resizing the window (because I think it forces the panorama to refresh). I added a callback function (which is similar to what we do in Onboarding) that will force the panorama to refresh itself. It should load without having to resize the window now.

I also modified the zoom levels in the admin panorama to more closely reflect what the user sees. (The zoomLevel seems to depend on what size the Google StreetView window is, which is sort of odd -- when I made the window bigger in #1308, I forgot to adjust the zoomLevel too).

Testing Instructions

  • Open the admin page. Go to page ~100(ish) on the contributions page, and try opening a few panoramas. Panoramas with the label should load properly (i.e. without resizing the window)
    • If the screen is black, open the developer window and see if there's a 404 error (if the panorama doesn't exist anymore, the screen will be black).
  • Go to Map page, and repeat the steps above.

@ghost ghost assigned aileenzeng Aug 28, 2018
@aileenzeng aileenzeng changed the title Resolves #967: Fixes initial blank panorama Resolves #976: Fixes initial blank panorama Aug 28, 2018
@misaugstad
Copy link
Member

Nice work on this one, it all checks out! High quality, as always 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants