Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] updated libraries and code changes #1406

Conversation

athersharif
Copy link
Collaborator

this is a wip pr. too much noise due to auto-styling changes. not ready for review yet but feel free to play with it.

@ghost ghost assigned athersharif Jan 25, 2019
@misaugstad
Copy link
Member

Oh no what happened with the style changes 😅 😅

@misaugstad
Copy link
Member

And does it compile right now?

@athersharif
Copy link
Collaborator Author

no clue, may have been my editor lol. really didn't want the styling changes there haha.

nope, not yet. started with 2000 errors, down to 1680. but i think i know the code changes needed for migration. some of these errors are also unused imports and unused vals which i don't think the previous version complained about when compiling.

@athersharif
Copy link
Collaborator Author

look at the changes in AuditController tho (https://github.com/ProjectSidewalk/SidewalkWebpage/pull/1406/files#diff-8932b9b74210fd7a8892d2c1ea80fc2eR3). down to 0 errors on that controller. so basically we'd need to apply the same kinda changes in other controllers. but that needs a thorough check that everything works. do we have a reliable test suite?

@ghost ghost removed the pull-request-submitted label Jan 25, 2019
@misaugstad misaugstad self-assigned this Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants