Resolves 1473: Improve load times after changes from within Docker container

[athersharif]

fixes #1473.

following #1364 (comment), this is a change to improve the load times after changes from within the container. this is a workaround to an issue that Docker for Mac has, and like every workaround, this should be thoroughly tested on other OSs as well. :)

we'd need to test:

• does this change improve load times on the docker container on Mac?
• does this change affect the functionality on Linux and Windows at all?
• are there any other performance degradations?
• is there anything we can improve wrt dockerizing that may or may not be related to this change?

here's a screen recording on Mac after this change (let me know if the link doesn't work): https://drive.google.com/open?id=1YpCilah2rhffCqGSYcIN6Fw5pfZ9QLS_

[misaugstad]

Dibs on Linux!

[misaugstad]

I didn't experience any performance degradation on Linux. Works just fine!

here's a screen recording on Mac after this change (let me know if the link doesn't work):

The link does not work (404 error)

[athersharif]

@misaugstad can you try https://drive.google.com/file/d/1YpCilah2rhffCqGSYcIN6Fw5pfZ9QLS_/view? seems like github took the trailing underscore out of the hyperlink lol.

[misaugstad]

Yep that works!

[misaugstad]

I didn't experience any performance degradation on Linux. Works just fine!

[athersharif]

cool. do we have reviews from Windows and Mac users?

[misaugstad]

I believe @shivenbhatt is doing Windows and has started but not finished reviewing. Haven't found a Mac user yet (but was waiting until we deployed to Newberg before I really pushed it on anyone else).

[athersharif]

i'd suggest having a mac user test it now as originally this issue was reported by @aileenzeng who is a mac user.

[aileenzeng]

@misaugstad @athersharif I can test on Mac! I’m in-between tasks atm and have some time now

[aileenzeng]

does this change improve load times on the docker container on Mac?

Yep! To change JavaScript files, it probably takes about ~20 seconds on my computer to make the change and reload the page (which is significantly better than what it was before!). In comparison, I think it takes about 15 seconds with the old setup.

are there any other performance degradations?

Changing .scala files (like controllers and such) takes longer - maybe around 2-3 minutes for the page to reload? I think on my local dev environment it takes 40 seconds for the page to reload.

[AmethystGear]

It takes a while longer to update JavaScripts on this new branch for windows. On this branch it takes around 40-60 seconds, on the develop branch it took around 10-12 seconds.

[misaugstad]

I'll also try to test on Windows myself this week.

[michaelduan8]

It seems that the :delegated flag is mainly intended as a performance tuning measure for Mac users (as shown in this docker documentation https://docs.docker.com/docker-for-mac/osxfs-caching/). For me (Mac), I'm getting very good speed ups, with my compile time for javascript changes taking before around 2-3 min and now averaging ~10 seconds. Similarly, for the sbt compile, I'm noticing it's now taking around ~15 seconds compared to the 1-2 min prior to testing this flag.

[jonfroehlich]

Wow, that's huge. Thanks!

…

On Mon, Jun 15, 2020 at 7:13 PM ThatOneGoat ***@***.***> wrote: It seems that the :delegated flag is mainly intended as a performance tuning measure for Mac users (as shown in this docker documentation https://docs.docker.com/docker-for-mac/osxfs-caching/). For me (Mac), I'm getting very good speed ups, with my compile time for javascript changes taking before around 2-3 min and now averaging ~10 seconds. Similarly, for the sbt compile, I'm noticing it's now taking around ~15 seconds compared to the 1-2 min prior to testing this flag. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1474 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAML55JHL3GT6DFJCB4FC3LRW3IKRANCNFSM4GX2NV2Q> .

-- Jon Froehlich Associate Professor Paul G. Allen School of Computer Science & Engineering University of Washington http://makeabilitylab.io @jonfroehlich <https://twitter.com/jonfroehlich> - Twitter Help make sidewalks more accessible: http://projectsidewalk.io

[mcdoerr]

I was running into (15sec - more than a minute) load times with the occasional extremely long load time of about 3 min. I fixed this issue by allocated more CPUs and memory to the docker container, through docker desktop.

The changes for the docker container were 1 CPU -> 4 CPUs and 2GB memory -> 4 GB memory, though I suspect the CPU is what made the difference, not the memory.

Load times are now under 10 secs.

Running on macos big sur 11.2.1, docker version 20.10.2