Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#954 GSV arrows no longer show in tutorial #2032

Merged
merged 8 commits into from
Mar 11, 2020
Merged

Conversation

michaelduan8
Copy link
Collaborator

Made it so the GSV nav arrows no longer show on tutorial

Resolves #954

@michaelduan8
Copy link
Collaborator Author

So the main issue I believe was that a "link" was provided to the custom pano made for the tutorial, which is why the arrow(s) showed up.

I mention this since the custom pano used in Admin Panorama for contributions made from the tutorial walkthrough also use the exact same custom pano, meaning it probably will also have a GSV appear. Just a heads up that this could be handled in another issue if needed, or I could just resolve that in this PR as well.

@misaugstad
Copy link
Member

So the main issue I believe was that a "link" was provided to the custom pano made for the tutorial, which is why the arrow(s) showed up.

I haven't tested yet, but have you tested that you can make it all the way through the tutorial with the change? Because I would assume that we would need to include that link for the "taking a step" to the 2nd pano in the tutorial to work.

I mention this since the custom pano used in Admin Panorama for contributions made from the tutorial walkthrough also use the exact same custom pano, meaning it probably will also have a GSV appear. Just a heads up that this could be handled in another issue if needed, or I could just resolve that in this PR as well.

Might as well make that change and include it in this PR as well for consistency.

@michaelduan8
Copy link
Collaborator Author

I’ve run the tutorial through a couple times and I’ve been able to make it through without problem, so I think it’s ok.

Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @ThatOneGoat !!

@misaugstad misaugstad merged commit 4dc45c0 into develop Mar 11, 2020
@misaugstad misaugstad deleted the 954-GSV-NAV-Arrows branch March 11, 2020 20:01
@misaugstad misaugstad mentioned this pull request Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants