-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#954 GSV arrows no longer show in tutorial #2032
Conversation
So the main issue I believe was that a "link" was provided to the custom pano made for the tutorial, which is why the arrow(s) showed up. I mention this since the custom pano used in Admin Panorama for contributions made from the tutorial walkthrough also use the exact same custom pano, meaning it probably will also have a GSV appear. Just a heads up that this could be handled in another issue if needed, or I could just resolve that in this PR as well. |
I haven't tested yet, but have you tested that you can make it all the way through the tutorial with the change? Because I would assume that we would need to include that link for the "taking a step" to the 2nd pano in the tutorial to work.
Might as well make that change and include it in this PR as well for consistency. |
I’ve run the tutorial through a couple times and I’ve been able to make it through without problem, so I think it’s ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @ThatOneGoat !!
Made it so the GSV nav arrows no longer show on tutorial
Resolves #954