Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1879 Mobile feedback button is sometimes partially hidden #2165

Merged
merged 8 commits into from
Jul 14, 2020

Conversation

shokiami
Copy link
Collaborator

@shokiami shokiami commented Jul 6, 2020

Resolves #1879
Fixes #2167

This PR fixes a visual bug experienced on the mobile validation info page where the feedback button is sometimes partially hidden. Specifically, it makes the info page scrollable as well as adjusts the size of the containers holding the images.

Before:
IMG_7563

After:
IMG_7562

@misaugstad
Copy link
Member

Okay I quickly fixed two tiny translation bugs I noticed while testing PRs. So that title at the top now actually says "What is an Obstacle?" Instead of "mobile.info-title-Obstacle".

The one issue I see is that the feedback button is at the very very bottom of the page. I think it would feel nicer if there was a bit of white space below it so you aren't worried about accidentally clicking on those controls at the bottom of the mobile browser. And to make it look good, you probably need to not have it be full width, it probably needs white space on the sides as well.

@shokiami
Copy link
Collaborator Author

shokiami commented Jul 9, 2020

@misaugstad Sounds good. Well get to that soon!

@shokiami
Copy link
Collaborator Author

shokiami commented Jul 9, 2020

Will*

@shokiami
Copy link
Collaborator Author

shokiami commented Jul 9, 2020

@misaugstad Let me know what you think!

@misaugstad
Copy link
Member

@shokiami can you include a screenshot?

@shokiami
Copy link
Collaborator Author

shokiami commented Jul 9, 2020

@misaugstad How does this look?
IMG_7584

@misaugstad
Copy link
Member

Ahh, in that screenshot I'm now noticing those faint lines between the different sections. Are those normally there? Can you get rid of those?

@shokiami
Copy link
Collaborator Author

@misaugstad What do you think?
IMG_7593

@misaugstad
Copy link
Member

Looks better! I will test soon :)

Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks good, thanks!

@misaugstad misaugstad merged commit 961f6fe into develop Jul 14, 2020
@misaugstad misaugstad deleted the 1879-infopage-feedback-button-hidden branch July 14, 2020 21:24
@misaugstad misaugstad mentioned this pull request Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants