-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1879 Mobile feedback button is sometimes partially hidden #2165
Conversation
…Webpage into 1879-infopage-feedback-button-hidden
Okay I quickly fixed two tiny translation bugs I noticed while testing PRs. So that title at the top now actually says "What is an Obstacle?" Instead of "mobile.info-title-Obstacle". The one issue I see is that the feedback button is at the very very bottom of the page. I think it would feel nicer if there was a bit of white space below it so you aren't worried about accidentally clicking on those controls at the bottom of the mobile browser. And to make it look good, you probably need to not have it be full width, it probably needs white space on the sides as well. |
@misaugstad Sounds good. Well get to that soon! |
Will* |
@misaugstad Let me know what you think! |
@shokiami can you include a screenshot? |
@misaugstad How does this look? |
Ahh, in that screenshot I'm now noticing those faint lines between the different sections. Are those normally there? Can you get rid of those? |
@misaugstad What do you think? |
Looks better! I will test soon :) |
…Webpage into 1879-infopage-feedback-button-hidden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works and looks good, thanks!
Resolves #1879
Fixes #2167
This PR fixes a visual bug experienced on the mobile validation info page where the feedback button is sometimes partially hidden. Specifically, it makes the info page scrollable as well as adjusts the size of the containers holding the images.
Before:

After:
