Fixes warning from multiple HTML elements with the same ID #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2040
Fixes the warnings about multiple HTML elements having the ID. The issue was that all of our various sign in/up methods used identical IDs. So the password field had the ID "password" on the sign in page, sign up page, in the navbar sign in, navbar sign up, and on the password reset page. Multiple of these fields could be present at the same time. For example, at /signIn, there was the password field in the main form on the page, plus the password fields in the sign and and sign up forms within the navbar.
This PR fixes this issue by changing the names of a few elements to make them unique and removing the sign in button from the navbar on /signIn and /signUp.