-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2840: Updated gallery cards for label types that do not support severity ratings #2954
Conversation
… out severity rating and hoverable tooltip that explains why they have no rating
I think that we can skip out on the '?' icon and just have the tooltip on the grayed out section. Do you have this on the expanded view when you click on a card as well? |
…tip and added it to the modal card popup as well, cleaned up redundant code
Since we dont have a grayed out image for the smiley faces in the expanded view I just made them grayed out circles when there's no severity rating, does that work? |
…, additional reorganization of forloop to prevent redundant code
…Webpage into 2840-gray-severity-levels
…ds with no severity rating
Here's the one thing from the list above that I think you missed!
|
…abels with no rating added
…Webpage into 2840-gray-severity-levels
@misaugstad Ready for another review! |
…Webpage into 2840-gray-severity-levels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added some super minor style changes. Everything is working great though! Just about ready to merge!
Ready for another check! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @GPA0VERKD :)
Resolves #2840
Changed Gallery cards with unsupported severity ratings to have grayed out severity ratings, as well as a tooltip that, wehn hovered over, explains why they have no rating.
Before/After screenshots (if applicable)
Before:
After:
Testing instructions
Things to check before submitting the PR