Fixes various street and neighborhood API bugs #3033
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3032
Resolves #974
This fixes a few bugs introduced by our recent PRs in the
/v2/access/score/streets
and/v2/access/score/neighborhoods
APIs, particularly on streets with no label data.Here's a mostly comprehensive list of bugs I found. All of these are new as of the most recent version.
attributes
andattributesWithLabels
endpointsnull
In addition, instead of saying whether a street has been audited, we now say how many audits the street has had (there are zero audits if it is unaudited).
And finally, I cleaned up the code to hopefully prevent further mistakes in the API, mostly by reusing more code!
Before/After screenshots (if applicable)
Before (streets API)
After
Things to check before submitting the PR