Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an info button to GSV window in Explore, Validate, and Gallery #3050

Merged
merged 34 commits into from
Oct 15, 2022

Conversation

misaugstad
Copy link
Member

Resolves #340

Adds an info button to the GSV window in Explore, Validate, and Gallery. It shows lat/lng, pano_id, street_edge_id, region_id, and label_id. The label_id is only shown on Validate and Gallery because you aren't focused on a single label on Explore. There is also a "View in GSV" button that opens GSV in a separate tab, pointing the location you are facing in our tool. There is also a button to copy the text of the table to your clipboard; the text looks like this (an example from the Validate screenshot below):

Latitude: 40.02551965977139°
Longitude: -82.9848103319417°
Panorama ID: wVC_rq_SQxB4FlisFJ2LnA
Street ID: 24068
Region ID: 176
Label ID: 11765

I've also added this data into LabelMap, but I just put it in the table with the reset of the data so that we didn't have two separate tables. As @jonfroehlich suggested, we should have a drop down "details" section that most of this stuff goes in.

Just some "After" screenshots!

Explore
Screenshot from 2022-10-14 16-34-12

Validate
Screenshot from 2022-10-14 16-34-49

Gallery
Screenshot from 2022-10-14 16-36-44

LabelMap
Screenshot from 2022-10-14 16-41-15

Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've added/updated comments for large or confusing blocks of code.
  • I've included before/after screenshots above.
  • I've asked for and included translations for any user facing text that was added or modified.
  • I've updated any logging. Clicks, keyboard presses, and other user interactions should be logged. If you're not sure how (or if you need to update the logging), ask Mikey. Then make sure the documentation on this wiki page is up to date for the logs you added/updated.
  • I've tested on mobile (only needed for validation page).

davphan and others added 30 commits September 2, 2022 10:48
…or audit page. Audit page is completely done, moving on to next GSV pane
…asks noted in public/javascripts/common/GSVInfoPopover.js, css moved from js to main.css
@misaugstad misaugstad self-assigned this Oct 14, 2022
@misaugstad misaugstad merged commit 4c9236b into develop Oct 15, 2022
@misaugstad misaugstad deleted the 340-long-lat branch October 15, 2022 00:26
This was referenced Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Showing Longitude and Latitude in the User Interface
2 participants