-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds an info button to GSV window in Explore, Validate, and Gallery #3050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clipboard copying (yet)
…ted, only on SVL and not all info
…or audit page. Audit page is completely done, moving on to next GSV pane
…asks noted in public/javascripts/common/GSVInfoPopover.js, css moved from js to main.css
This was referenced Oct 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #340
Adds an info button to the GSV window in Explore, Validate, and Gallery. It shows lat/lng,
pano_id
,street_edge_id
,region_id
, andlabel_id
. Thelabel_id
is only shown on Validate and Gallery because you aren't focused on a single label on Explore. There is also a "View in GSV" button that opens GSV in a separate tab, pointing the location you are facing in our tool. There is also a button to copy the text of the table to your clipboard; the text looks like this (an example from the Validate screenshot below):I've also added this data into LabelMap, but I just put it in the table with the reset of the data so that we didn't have two separate tables. As @jonfroehlich suggested, we should have a drop down "details" section that most of this stuff goes in.
Just some "After" screenshots!
Explore
Validate
Gallery
LabelMap
Things to check before submitting the PR