Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing mission screens for browser zoom levels: 110%, 125%, and 133%. #3108

Merged
merged 4 commits into from
Feb 3, 2023

Conversation

hoominchu
Copy link
Collaborator

@hoominchu hoominchu commented Jan 12, 2023

Resolves #3103

The validate mission screens were looking bad at different zoom levels. This PR fixes it with some CSS changes and media queries.

Before/After screenshots (if applicable)

Before
Screenshot 2023-01-12 at 12 56 02 PM

After
Screenshot 2023-01-12 at 12 55 28 PM

Testing instructions
  1. Open the validate mission tutorial.
  2. Change the browser zoom to the following levels: 110%, 125%, and 133%.
  3. Ensure that the layout is optimum in all cases.
Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've added/updated comments for large or confusing blocks of code.
  • I've included before/after screenshots above.

Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hoominchu looking much better at those high zoom levels!

@misaugstad misaugstad merged commit 9e3b8af into develop Feb 3, 2023
@misaugstad misaugstad deleted the 3103-validate-misson-on-zoom branch February 3, 2023 23:26
@misaugstad misaugstad mentioned this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate mission tutorial looks really bad at high zoom level
2 participants