Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getRegionId #3117

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Fix getRegionId #3117

merged 1 commit into from
Feb 3, 2023

Conversation

kevinjtwu
Copy link
Collaborator

Resolves #3087

Fixed Region ID not showing on GSV info popup on the Explore page.

Before/After screenshots (if applicable)

Before:
image
After:
image

Testing instructions
  1. Navigate to Explore page and click on the GSV info button to see popup.
Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've added/updated comments for large or confusing blocks of code.
  • I've included before/after screenshots above.

misaugstad
misaugstad approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @kevinjtwu, glad we got there!!

@misaugstad misaugstad merged commit 2fb7b12 into develop Feb 3, 2023
@misaugstad misaugstad deleted the 3087-region-id-gsv-popup branch February 3, 2023 23:24
@misaugstad misaugstad mentioned this pull request Feb 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misaugstad misaugstad misaugstad approved these changes

Assignees

@misaugstad misaugstad

@kevinjtwu kevinjtwu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Region ID not shown on GSV info popup on Explore
2 participants
@kevinjtwu @misaugstad