Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3057 remove pedistrian signal histogram admin #3148

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

sneh721
Copy link
Collaborator

@sneh721 sneh721 commented Feb 24, 2023

Resolves #3057

Removed Pedestrian signal severity histogram from admin page, along with the corresponding average and standard deviation. Resized the remaining histograms.

Before:
image

After:
image

Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've added/updated comments for large or confusing blocks of code.
  • I've included before/after screenshots above.

…the he relevant statistics (average and standard deviation). Resized the remaining histograms to be bigger.
Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment to address!

public/javascripts/Admin/src/Admin.js Show resolved Hide resolved
Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @sneh721 !

@misaugstad misaugstad merged commit 8a40439 into develop Feb 28, 2023
@misaugstad misaugstad deleted the 3057-remove-pedistrian-signal-histogram-admin branch February 28, 2023 21:19
@misaugstad misaugstad mentioned this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Pedestrian Signal severity histogram from Admin page
2 participants