-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.13.0 #3200
Merged
Merged
7.13.0 #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug where labels moved after placing them
…-env-var Adds Mapbox API key as an environment variable
…Webpage into 2485-fix-old-sv-xy-data
Fixes old sv_image_x/y data, renames some db columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below are the specific changes to know for anyone who uses our
/adminapi/panos
,/adminapi/labels/panoid
,/adminapi/labels/cvMetadata
,/v2/access/score/streets
,/v2/access/score/neighborhoods
,/v2/access/attributes
, or/v2/access/attributesWithLabels
APIs.Note: only GeoJSON and CSV APIs are affected, nothing has changed for Shapefiles due to a 10 character max for attribute names.
/adminapi/panos
and/adminapi/labels/panoid
image_width
renamed towidth
image_height
renamed toheight
photographer_heading
renamed tocamera_heading
photographer_pitch
renamed tocamera_pitch
/adminapi/labels/cvMetadata
image_width
renamed topano_width
image_height
renamed topano_height
photographer_heading
renamed tocamera_heading
photographer_pitch
renamed tocamera_pitch
sv_image_x
renamed topano_x
sv_image_y
renamed topano_y
/v2/access/score/streets
(GeoJSON & CSV only)avg_image_date
renamed toavg_image_capture_date
/v2/access/score/neighborhoods
(GeoJSON & CSV only)avg_image_date
renamed toavg_image_capture_date
/v2/access/attributes
(GeoJSON & CSV only)avg_image_date
renamed toavg_image_capture_date
/v2/access/attributesWithLabels
(GeoJSON & CSV only)image_date
renamed toimage_capture_date
Furthermore, if you are using our APIs for computer vision work (likely with some of the
/adminapi/panos
,/adminapi/labels/panoid
, or/adminapi/labels/cvMetadata
APIs), then you will also need to know about the following updates (roughly in order of importance):sv_image_y
(now calledpano_y
) to range from 0 topano_height
, where 0 is at the top of the image. In the past, we were outputting the y-pixel offset from the center of the image. Instead of having to computepano_y = pano_height / 2 - sv_image_y
, you should now just usepano_y
.sv_image_x
(now calledpano_x
) data have been fixed, so you should remove any post-hoc fixes in your code for them. The following have been fixed (and have been fixed retroactively for all data):pano_x
values that were wildly incorrect in edge cases.photographer_heading
(now calledcamera_heading
) of the GSV image. You should remove corrections based onphotographer_heading
that you are doing yourself.heading
to an integer when calculatingpano_x
.sv_image_y
(now calledpano_y
) data have been fixed, so you should remove any post-hoc fixes in your code for them. Unlike withpano_x
, we still have a source of error inpano_y
that we haven't been able to resolve yet -- there seems to be some level of error in the pitch that is different at different headings, which is exacerbated by hilly streets. But the following has been fixed (and has been fixed retroactively for all data):pitch
to an integer when calculatingpano_y
.