Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Labeling Guide curb ramp summary text #3280

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

tanayaxsharma
Copy link
Collaborator

@tanayaxsharma tanayaxsharma commented Jun 28, 2023

Resolves #2992 (updates labeling guide curb ramp summary text)

Updated the curb ramp labeling guide introduction to also include a statement emphasizing that all curb ramps should be labeled, regardless of whether there are issues.

Appended the sentence as well as the ADA hyperlink to the messages.en file (removed the ADA hyperlink from the labelingGuideCurbRamps.scala.html file).

Before/After screenshots

Before:
image

After:
image

Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I'll add translations into other languages myself before merging the PR.

Can you also change the title of the PR to something that better describes the change, like "Updates Labeling Guide curb ramp summary text"

@tanayaxsharma tanayaxsharma changed the title Changes for issue #2992 Updates Labeling Guide curb ramp summary text Jun 28, 2023
@misaugstad misaugstad merged commit 2c3a69c into develop Jul 6, 2023
@misaugstad misaugstad deleted the 2992-append-curb-ramp-labeling-guide branch July 6, 2023 21:27
@misaugstad misaugstad mentioned this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update labeling guide to emphasize to label every curb ramp (not just deficient curb ramps)
2 participants