Adds alt text for images on landing page #3285
Conversation
…Webpage into 2522-alt-text-for-images
There was a problem hiding this comment.
I added 2 comments in the code. Could you also look for alt text for any other images that we already have that isn't very helpful and update them (I'm thinking about the collaborator logos). Those logos have alt text like "Makeability_Logo" which isn't very helpful!
conf/messages
Outdated
| @@ -3,4 +3,4 @@ error.required = This field is required | |||
| invalid.credentials = Invalid credentials! | |||
| access.denied = Access denied! | |||
| user.exists = There already exists a user with this email! | |||
| could.not.authenticate = Could not authenticate with social provider! Please try again! | |||
| could.not.authenticate = Could not authenticate with social provider! Please try again! | |||
There was a problem hiding this comment.
Make sure to keep newlines at the ends of files!
|
Can you clean up the PR a bit more before I review again? There are translations in the en-NZ file that shouldn't be there, and not all of the new images with alt text have the text in translations files. Apologies if I looked before you had finished updating the PR. When you're done making updates and the a PR is ready for another review, please post a message on that PR like this so that I know that you're done! |
|
Also, the messages.zh files has been renamed to messages.zh-TW, so there is a conflict to resolve, unfortunately! |
|
Can you resolve merge conflicts before I review? I suppose I should wait until after the People Nudge logo PR has been merged as well, but merge conflicts are going to need to be fixed at some point anyway! |
|
It shouldn't be too bad. Really all that we did was rename "messages.zh" to "messages.zh-TW" and Github doesn't know how to handle that automatically. |
kevinjxc
force-pushed
the
2522-alt-text-for-images
branch
2 times, most recently
from
861910d to
9cc656a
Compare
…d alt text for footer collaborators, fixes structure of skyline if-statement
There was a problem hiding this comment.
Looks good! I did make a couple changes myself, listed below:
- As per style guide, make sure that your files end with newlines. When you added to the messages files, you removed the blank lines at the ends of files.
- We only need to include a "en-NZ" translation if it's different from "en". As such, I was able to remove all the translations you added to that file.
misaugstad
changed the title
Resolves #2522
Add alt text for images