Added button tooltips #3286
Added button tooltips #3286
Conversation
There was a problem hiding this comment.
Sorry for taking so long to review this one!
- Could you change the style of the tooltips on the Validate page to match those on the Explore page? Sorry, I didn't realize that we already had a couple with a different style! And to be clear: this is just for the buttons on the top and left of the GSV window.
- Could you add translations to other languages using Google Translate? Apologies if I told you that I would do this part before 😅 I did write up some better instructions for it here
app/views/validation.scala.html
Outdated
| @@ -63,7 +63,7 @@ | |||
| <img src='@routes.Assets.at("javascripts/SVLabel/img/icons/comment.png")' alt="Comment icon" align=""> | |||
| <br> | |||
| @Html(Messages("feedback")) | |||
| </div> | |||
| </div> | |||
There was a problem hiding this comment.
Can you remove the accidental whitespace?
|
I changed the formatting of the tooltips for the skip and feedback buttons and deleted the addition white space in one of the files. Here are some updated screenshots: Skip Button: Feedback Button: |
|
Also, added language translations! |
…Webpage into 227-adds-tooltips-to-buttons
There was a problem hiding this comment.
I started testing and noticed that the Stuck button is messed up in Spanish. Make sure to test all the buttons in each language, it doesn't take too long! 😉
I think that since you started working on this, we've added German translations (de). Could you add German translations as well?
| @@ -241,6 +240,11 @@ function Main (params) { | |||
| }); | |||
| } | |||
| }); | |||
| $("#feedback-button-tooltip").tooltip({ | |||
There was a problem hiding this comment.
Why doesn't the feedback tooltip work like the other ones, and needs it's own call here? Why can't it be included in the $('[data-toggle="tooltip"]').tooltip({ bit below?
|
I have fixed the tooltip issues in different languages and added translations for German as well. After attempting to remove the call to the feedback tooltip and trying to include it in the general call below that, I think that the reason it needs its own call is because the text associated with it lies within Would you like me to move the text from |
Yeah let's do that, let's try and keep it consistent between the different tooltips. I'm wondering if part of the issue is that the feedback tooltip looks like it's set up differently from the other ones. The others look like this: the feedback one looks like But maybe it was done this way because there's a popover that shows up briefly when feedback is submitted? Might need a bit more testing.
We generally put translations that are shared on multiple pages near the top of the message file. You could probably put it right after this line: And the last thing is to pull in changes from develop and resolve merge conflicts. Thank you @tanayaxsharma !! |
|
I have changed the code so that the text associated with the feedback button's tooltip is now in the messages files instead of the I believe that even though the feedback tooltip is set up differently, it is still functioning correctly after changing just the text's location. Let me know if you would like me to make any additional changes. |
Resolves #227
Adds tooltips to skip, stuck, jump, and feedback buttons on both the validate and explore pages. For the skip, stuck, and jump buttons, the messages.en, validation/explore.scala.html files were utilized. For the feedback button, common.json and the corresponding Main.js files under SVLabel and SVValidate were used.
Before/After screenshots