Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds unexplored tasks to minimap #3287

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Conversation

kevinjtwu
Copy link
Collaborator

@kevinjtwu kevinjtwu commented Jul 8, 2023

Resolves #3170

On page load, render all tasks (only time this will be done). Every time task is completed, update only the new current task (render: erase gray and draw red/green) once old current task has ended. If user jumps to another location within the same neighborhood, store old current task (incomplete) right before new current task is set. Then once new current task is set, rerender the old current task.

Before/After screenshots (if applicable)

3170_minimap_tasks_fix

Testing instructions
  1. Navigate to Explore page
  2. See minimap
  3. Jump within neighborhood by selecting Jump in left side bar, then 'I want to explore another area!' then 'Go to a new location in this neighborhood'
Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've added/updated comments for large or confusing blocks of code.
  • I've included before/after screenshots above.

Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! I'm glad that after all the hard work, the code changes ended up looking rather simple. That generally means that it was done well :)

I just renamed a function and simplified an if statement, nothing major at all.

I am going to wait to merge, likely until after @crescendochu and @iamZhihanZhang are done with their current user study. But consider it approved!!

@misaugstad misaugstad merged commit 97812dc into develop Aug 25, 2023
@misaugstad misaugstad deleted the 3170-minimap-route-info branch August 25, 2023 22:55
@misaugstad misaugstad mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visualize more route info in the minimap
2 participants