Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1261 label reopen context menu #3295

Merged
merged 8 commits into from
Aug 29, 2023
Merged

Conversation

kevinjtwu
Copy link
Collaborator

Resolves #1261

For a label with context menu open, clicking on the label no longer closes the menu on mouse down and reopens it on mouse up.

Testing instructions
  1. Navigate to Explore page
  2. Place label and open context menu
  3. Click on label with context menu open
Things to check before submitting the PR
  • I've written a descriptive PR title.

Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label now longer does a close and reopen, but it isn't closing at all! We still want it to close when you click on it, just not reopen again :)

@kevinjtwu
Copy link
Collaborator Author

The label now longer does a close and reopen, but it isn't closing at all! We still want it to close when you click on it, just not reopen again :)

Fixed! Label now closes on mouse down (and stays closed) when you click on the label instead of not closing at all.

Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay @kevinjtwu it looks like you accidentally deleted some code during a merge, but I believe I've got it all fixed up! I also did a small refactor from what you did, and deleted some of the code from your old commits. Just make sure to check Github's "Files changed" tab for your PR in the future to make sure that everything is cleaned up before I review.

And please take a look at how the code ended up looking and let me know if something looks wrong to you!

@misaugstad misaugstad merged commit 32cc007 into develop Aug 29, 2023
@misaugstad misaugstad deleted the 1261-label-reopen-context-menu branch August 29, 2023 22:12
@misaugstad misaugstad mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on label closes and then reopens context menu
2 participants