draws grey remaining-in-route line for RouteBuilder routes

[lindseyehrlich]

Resolves #3204

Draws grey "remaining in your route" line in the mission complete maps for routes created with RouteBuilder.

Before/After screenshots (if applicable)

Testing instructions

Things to check before submitting the PR

• I've written a descriptive PR title.
• I've added/updated comments for large or confusing blocks of code.
• I've included before/after screenshots above.

[misaugstad]

@lindseyehrlich so it looks like the bug you fixed may have been introduced since the time that I filed #3204! In the screenshot I shared there, the remainder of the route is being drawn correctly. Thank you for fixing that so that it's working again 😅

But the issue that was brought up was that the remainder of the task that the user is in the middle of working on isn't getting drawn in gray. It isn't entirely clear from your screenshot if this is working correctly or not, but I think it's not.

Pasting my original screenshot below for reference. On the right side, you can see that I was part of the way through that street, and the part I've finished is shown in green. But the remainder of the street isn't shown at all, and should be shown in gray. If you make your routes into loops then it's really easy to see if it's working :)

[lindseyehrlich]

Ah, I see! I think the code I wrote fixes both issues. I tested it a few times with different routes and I haven't come across any gaps between green and grey lines. The for loop I wrote draws a grey line for any street that's incomplete and the green line is drawn on top depending on how far the user got into the street. Here's a screenshot from one of my tests in which I made the route into a loop:

[misaugstad]

Looks like it's working for "Routes" but it isn't working in the general case! If you're not on a route and someone has already audited a street that you've partially finished, it isn't showing the rest of the line as having been audited by someone else.

That's because of this if statement:

if (userOldStreets.indexOf(otherUserStreet) === -1 && newStreets.indexOf(otherUserStreet) === -1)

It's basically saying that any street that's part of the current mission shouldn't be drawn. But we should at least draw the portion that that you haven't finished auditing yet on your current street!

[jonfroehlich]

@crescendochu and I are reviewing her study routes and we also came across a related issue. There should be no disconnect here:

It should look like this:

Should we file a new issue? Also, this ideally would be fixed before the study occurs...

[misaugstad]

we also came across a related issue. There should be no disconnect here ... Should we file a new issue?

This is the exact issue that's being fixed here!

this ideally would be fixed before the study occurs...

Given that @lindseyehrlich fixed this for the case or user-defined routes in this PR already, we should be able to just merge this one before the study and then she can work on the other case for another PR!

[lindseyehrlich]

Ready for another PR review

[misaugstad]

Looks great, thanks @lindseyehrlich !!