Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pano date properly updates #3315

Merged
merged 5 commits into from
Jul 27, 2023
Merged

pano date properly updates #3315

merged 5 commits into from
Jul 27, 2023

Conversation

dylanbun
Copy link
Collaborator

Resolves #3304

Pano date updates correctly, had to change one line regarding which field to grab to mark as the date.

Before/After screenshots

Before:

initial_validate_wrong

initial_validate_wrong_maps

After:

Screenshot_2023-07-24_at_10 30 14_PM Screenshot_2023-07-24_at_10 30 38_PM
Testing instructions
  1. Go to Validate page
  2. Look at pano date
  3. Verify if pano date matches the one on Google Maps
Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've added/updated comments for large or confusing blocks of code.
  • I've included before/after screenshots above.
  • [????] I've tested on mobile (only needed for validation page)

@dylanbun dylanbun requested a review from misaugstad July 25, 2023 05:35
@dylanbun dylanbun self-assigned this Jul 25, 2023
@dylanbun
Copy link
Collaborator Author

@misaugstad ready for review now!

@misaugstad misaugstad self-assigned this Jul 27, 2023
misaugstad
misaugstad approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dylanbun! I definitely broke this, thanks for fixing :)

@misaugstad misaugstad merged commit c31a59b into develop Jul 27, 2023
@misaugstad misaugstad deleted the 3304-pano branch July 27, 2023 18:31
@misaugstad misaugstad mentioned this pull request Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misaugstad misaugstad misaugstad approved these changes

Assignees

@misaugstad misaugstad

@dylanbun dylanbun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The pano date is stuck on July 2023
2 participants
@dylanbun @misaugstad