#3292 ClusterSize & #3293 Neighborhood Name #3323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misaugstad
requested changes
Jul 27, 2023
There was a problem hiding this comment.
Thanks @1kechen! Just a few requests in addition to the comments:
- Looks like you made the changes for the JSON and CSV APIs, but not for the Shapefile APIs. You should make the changes there too! It's probably easiest to test the shapefiles by looking for some website that will visualize small shapefiles for you :)
- Are you creating the PR through the Github website or on the command line? If you're not already, you should do it through the website and use the provided template!
- Next time I would suggest splitting this into two separate PRs so that we can merge one of them even if there are problems with the other, but this is fine for now!
misaugstad
requested changes
Aug 18, 2023
kevinjxc
force-pushed
the
3292-3293-neighborhood-name-and-cluster-size-properties
branch
from
0d23a8a
to
7213090
Compare
…Webpage into 3292-3293-neighborhood-name-and-cluster-size-properties
misaugstad
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
@1kechen Did you check that the shapefiles worked? The max number of characters for a field in a shapefile is 10 characters. Your field names "clusterSize" and "neighborhoodID" had 11 and 14 characters respectively, which corrupted the actual data and turned it to null. I've renamed them to "clusterSze" and "nghborhdId" and they work now.
Please make sure to test all of your code!
misaugstad
deleted the
3292-3293-neighborhood-name-and-cluster-size-properties
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3292, #3293
Add clusterSize property, streamline region variables to neighborhood variables.