Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config table fix #3332

Merged
merged 7 commits into from
Aug 1, 2023
Merged

config table fix #3332

merged 7 commits into from
Aug 1, 2023

Conversation

dylanbun
Copy link
Collaborator

@dylanbun dylanbun commented Aug 1, 2023

Resolves #3322

Cleaned up the config table with two generic classes for data, an ApiField and LatLngPair case class. Removed the many getter methods. Refactored ConfigController to reduce queries.

Things to check before submitting the PR
  • I've written a descriptive PR title.

@dylanbun dylanbun requested a review from misaugstad August 1, 2023 20:02
@dylanbun dylanbun self-assigned this Aug 1, 2023
misaugstad
misaugstad approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Both to you, and to GPT 4 for helping to figure out that one instance of weird syntax that made the code look so much cleaner. Please don't be offended because I renamed everything 😉

@misaugstad misaugstad merged commit c55e43f into develop Aug 1, 2023
@misaugstad misaugstad deleted the 3322-config-fix branch August 1, 2023 22:52
@misaugstad misaugstad mentioned this pull request Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misaugstad misaugstad misaugstad approved these changes

Assignees

@dylanbun dylanbun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up Config table Scala code
2 participants
@dylanbun @misaugstad