Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an experimental prediction model to our "crowdstudy" server #3347

Merged
merged 70 commits into from
Aug 9, 2023

Conversation

misaugstad
Copy link
Member

Resolves #3278

Incorporates a model to predict whether a label is correct into the Explore page. After the user closes the context menu for the label, we use the label's metadata to predict whether the label is correct (using things like severity, distance from an intersection, etc).

We are running our first pilot studies with this model, so the UI is only available on our experimental "crowdstudy" server.

Screenshots!

Screenshot from 2023-08-08 20-58-07
Screenshot from 2023-08-08 20-58-24
Screenshot from 2023-08-08 20-58-36

Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've added/updated comments for large or confusing blocks of code.
  • I've included before/after screenshots above.
  • I've updated any logging. Clicks, keyboard presses, and other user interactions should be logged. If you're not sure how (or if you need to update the logging), ask Mikey. Then make sure the documentation on this wiki page is up to date for the logs you added/updated.

hoominchu and others added 30 commits July 24, 2023 22:04
Handling interaction flows.
Connecting UI to model backend.
… prediction-model

# Conflicts:
#	public/javascripts/SVLabel/src/SVLabel/PredictionModel.js
@misaugstad misaugstad merged commit 6ce085d into develop Aug 9, 2023
@crescendochu
Copy link
Collaborator

Thank you so much @misaugstad @hoominchu and everyone else who made this possible!!! T.T

@jonfroehlich
Copy link
Member

jonfroehlich commented Aug 9, 2023

Awesome work team! 🎉 It looks like the initial pop-up dialog might have incorrect static text?

In this case, it's a "Are you sure this is a surface problem" but then it says that "48% of Curb Ramps are missed by users"

image

Have we finalized text for this part? If not, might I suggest (could randomly show the tips per label type—my worry is that if we don't prefix the sentence by "tip", that the user might think the tip is exactly associate with their mistake but it's not):

For Surface Problems:

  • "Tip: only label problems that are on the pedestrian path"
  • "Tip: do not label driveways if they have surface problems"
  • "Tip: always check sidewalks on both sides of the road"

For Obstacles:

  • "Tip: an obstacle blocks the pedestrian path with limited space to avoid"
  • "Tip: only label obstacles that are on the pedestrian path"

For Missing Curb Ramps:

  • "Tip: do not label residential walkways (house-to-curb paths) as missing curb ramps"
  • "Tip: if there is no sidewalk, use the "missing sidewalk" and not "missing curb ramp"

For Curb Ramps:

  • "Tip: do not label driveways as curb ramps"
  • "Tip: do not label sidewalk-to-alleyway transitions as curb ramps unless a ramp is clearly visible"

For Missing Sidewalks:

  • "Tip: always double check that a sidewalk is actually missing"
  • "Tip: if a sidewalk exists but a curb ramp is missing, use the missing curb ramp label"

@crescendochu
Copy link
Collaborator

Looks like the pop up window text and image sizes does not resize super well with different screen sizes. Top one from Zhihan's 27 inch and bottom from mine 34 inch. It works perfect on a 13 inch laptop though. @misaugstad @hoominchu Thank you!!! I can also help calculating the em sizes if needed!

image

image

@jonfroehlich
Copy link
Member

Ugh, this is definitely a @hoominchu fix; however, they have a major MHCID deadline on Monday—so not sure if they can manage it.

Could @misaugstad do it? Otherwise, how well do you or Zhihan know HTML/CSS?

@hoominchu
Copy link
Collaborator

Does it make sense to restrict the width of the popup on an ultra wide display? If yes, we can add max-width and that should solve the problem.

@jonfroehlich
Copy link
Member

I think that sounds like a great idea.

@crescendochu
Copy link
Collaborator

@hoominchu not sure if I was being clear... the font sizes also become really small as the screen resolution increase. I can help calculating the em sizes if needed!

@hoominchu
Copy link
Collaborator

I have pushed a fix for the popup size issue.
@crescendochu yeah it'll be great if you could provide me the em sizes!

UI development is messy cause of all these different screen sizes, resolution, platforms etc. 🥲

@crescendochu
Copy link
Collaborator

Thank you so much @hoominchu! Don't worry I know how messy it is haha, and you've done an awesome job! Just let me know the current font sizes and I can give u the measurements in em!

@crescendochu
Copy link
Collaborator

Based on my conversation with @hoominchu, bootstrap base font size is 14px, so here's the conversion:

  • titles: 24px -> 1.7 rem
  • back-to-labeling button: 12px -> 0.85 rem
  • see common mistakes/correct examples: 16px -> 1.1 rem

Let me know if this works!

@hoominchu
Copy link
Collaborator

Thanks! I have pushed the fix!

@misaugstad misaugstad mentioned this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate ML model from Chu/Zhihan into CrowdStudy Explore page
5 participants