-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Crosswalk and Pedestrian Signal labels to tutorial #3388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh! And I fixed the bug where old flashing arrows would show up after deleting a label (#3318). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2846
Fixes #3318
Adds Crosswalk and Pedestrian Signal labels to the tutorial. To try and keep the length of the tutorial from ballooning too much, I removed some of the labels that were redundant; instead, I add the labels to the pano for the user and explain that that's what's happening.
We received translations from our partners in Chinese and German. I didn't hear back from our partners who typically provide Dutch translations. And we don't currently have someone to provide Spanish translations. I have a spreadsheet where I record translations that we need though, so I will be able to hand it off to new translators when we have them!
Screenshots of the new content (skipping some less exciting ones for (relative) brevity)
Things to check before submitting the PR