Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Crosswalk and Pedestrian Signal labels to tutorial #3388

Merged
merged 29 commits into from
Sep 22, 2023

Conversation

misaugstad
Copy link
Member

@misaugstad misaugstad commented Sep 21, 2023

Resolves #2846
Fixes #3318

Adds Crosswalk and Pedestrian Signal labels to the tutorial. To try and keep the length of the tutorial from ballooning too much, I removed some of the labels that were redundant; instead, I add the labels to the pano for the user and explain that that's what's happening.

We received translations from our partners in Chinese and German. I didn't hear back from our partners who typically provide Dutch translations. And we don't currently have someone to provide Spanish translations. I have a spreadsheet where I record translations that we need though, so I will be able to hand it off to new translators when we have them!

Screenshots of the new content (skipping some less exciting ones for (relative) brevity)

Screenshot from 2023-09-21 16-46-32
Screenshot from 2023-09-21 16-47-27
Screenshot from 2023-09-21 16-47-38
Screenshot from 2023-09-21 16-48-03
Screenshot from 2023-09-21 16-48-13
Screenshot from 2023-09-21 16-48-27
Screenshot from 2023-09-21 16-48-41
Screenshot from 2023-09-21 16-48-56
Screenshot from 2023-09-21 16-49-32
Screenshot from 2023-09-21 16-49-41
Screenshot from 2023-09-21 16-50-02
Screenshot from 2023-09-21 16-50-14

Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've added/updated comments for large or confusing blocks of code.
  • I've included before/after screenshots above.
  • I've asked for and included translations for any user facing text that was added or modified.

@misaugstad misaugstad self-assigned this Sep 21, 2023
@misaugstad
Copy link
Member Author

Oh! And I fixed the bug where old flashing arrows would show up after deleting a label (#3318).

@misaugstad misaugstad merged commit d0f2e0a into develop Sep 22, 2023
@misaugstad misaugstad deleted the 2846-tutorial-add-crosswalk-and-signal branch September 22, 2023 00:09
@misaugstad misaugstad mentioned this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant