-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dropdown links to download API calls from the API page. #3406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functionality seems great! Most of these edits have to do with rewriting some of the text and such on the API page to accommodate the changes you've made!
-
Let's have separate widgets for /attributes and /attributesWithLabels
-
The lat/lng bounds should be listed as "Optional" instead of "Required". This just means removing the entire "Required" category and moving the lat/lngs part inside the "Optional" section.
-
In places where you see this sentence
If you need data for the entire city, you can use the parameters below
Replace it with
If you need data for the entire city, you can use the download button above or you can simply exclude the lat/lng parameters.
-
There are more changes to make given that the params are now optional... Just use your best judgement and try to get the page to work with the now optional parameters and download widgets!
-
The download widgets are kinda floating way higher than the titles that are in the same row. Can you add some margin to the buttons or something to move them more in line with the text? It just looks kinda clunky rn
-
Let's also open the URLs in the widgets in a new tab!
@misaugstad Ready for another review! |
Resolves #3237
Non-technical users were having trouble downloading API data for external usage. Dropdown buttons were added to the three major API calls (attributes with labels, score streets, and score neighborhoods) with one-click download options for CSV, Shapefile, and GeoJSON format.
GeoJSON format links to the JSON in browser rather than downloading a JSON file.
Before/After screenshots (if applicable)
Before:
After:
Testing instructions
Things to check before submitting the PR