Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lat/Lng inputs to all v2 API requests made optional. #3407

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

davphan
Copy link
Collaborator

@davphan davphan commented Oct 17, 2023

Resolves #3298

Lat and lng inputs were required for most of the API requests. Now Lat/lng inputs are optional and if left empty will autofill with the edge boundaries for the designated city. Only changed in the v2 API requests.

Before/After screenshots (if applicable)

Before:
image

After:
image

Testing instructions
  1. Test each of the following APIs:
  • /v2/access/attributes
  • /v2/access/attributesWithLabels
  • /v2/access/score/streets
  • /v2/access/score/neighborhoods
    Can be tested with combinations of different missing/defined lat/lng, and other optional parameters (i.e. filetype)
     
Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've added/updated comments for large or confusing blocks of code.
  • I've included before/after screenshots above.

Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The text on the API wasn't updated and should have been (the params are still listed as required instead of optional), but we can fix that in your other PR to simplify things a bit.

@misaugstad misaugstad merged commit 4e11f2a into develop Oct 23, 2023
@misaugstad misaugstad deleted the 3298-remove-lat-lng-api branch October 23, 2023 22:57
@misaugstad misaugstad mentioned this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove requirement for passing lat/lngs to APIs
2 participants