-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds automatic CSS zoom for Explore/Validate pages #3450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#303 is the issue we're working on here. This is a temporary fix because it doesn't work for Firefox.
Resolves #2535 as well
Adds automatic zoom on the Explore and Validate pages using the CSS zoom property instead of browser zoom. This doesn't work on Firefox. I've tested that it works on Chrome and Safari thus far, so that's all I've enabled. I'll test it on Edge in the next couple of weeks and enable it there if it works well too. Everything below the navbar gets zoomed.
I also removed the footers on both of those pages, which makes the app take up basically the entire screen with no scrolling ever happening on the page. Easy enough to add the footers back in, but I really like how it looks/feels with no scrolling.
Before/After screenshots (if applicable)
Before (80% zoom)
After (80% zoom)
Things to check before submitting the PR