#3413 Shapefile format doesn't allow integers longer than 9 digits

[SanyamSavla]

Resolves #3413

Shapefile format doesn't allow integers longer than 9 digits

Fixed the bug!
Also changed the data type for "osmWayId" to BIGINT as INT data type does not take more than 9 digits.
Added Evolutions file for Database migration.

Things to check before submitting the PR

• I've written a descriptive PR title.
• I've added/updated comments for large or confusing blocks of code.

[misaugstad]

I added a couple comments regarding code style/cleanup. But the main issue is that this didn't work for me for numbers that don't fit as an Int.

You've fixed the issue where the numbers fit into a postgres/scala Int but are more than 9 digits. So the number 1234567890 now works when it didn't before.

But if I test the API with the number 12345678901, I get this error:
Execution exception[[PSQLException: Bad value for type int : 12345678901]]

Were you not getting this error when testing the API?

[misaugstad]

Oh! And you can remove elements of the PR template that don't apply to you to keep it looking clean. I just edited yours as an example.

[misaugstad]

Okay there's no way that this code should be working for you unless you're testing on streets/neighborhoods that don't have any labels on them. You haven't updated all the locations where the OSM ID is used. If you do a search through the code for "osm_way_id", you'll see that it's used in GlobalAttributeTable.scala in two different case classes, both of which are still treading the OSM ID as an Int.

[misaugstad]

I found some more code that was meant for your other PR but removed it. Tested and it looks good, thank you!